chore: add explicit type definitions to consumer arrays and datetime utils#641
Merged
turnipdabeets merged 3 commits intoJun 2, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adds/strengthens type hints in utility and consumer code, improving static analysis and readability.
Changes:
- Added
datetime/timedeltaand return/arg type annotations inposthog/utils.py. - Added
Anyimport and typeditemsinConsumer.next().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| posthog/utils.py | Adds type annotations for datetime helpers and string utility. |
| posthog/consumer.py | Adds typing for the upload batch list in next(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Reviews (1): Last reviewed commit: "chore: add explicit type definitions to ..." | Re-trigger Greptile |
turnipdabeets
approved these changes
Jun 2, 2026
Contributor
turnipdabeets
left a comment
turnipdabeets
left a comment
There was a problem hiding this comment.
LGTM, thanks @mishrak5j
turnipdabeets
force-pushed
the
chore/improve-sdk-type-hints
branch
from
e08ce16 to
463cdaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
This PR improves static analysis verification and type safety across
utils.pyandconsumer.py.posthog/utils.py: Added concrete type annotations to foundational datetime utility methods (is_naive,total_seconds,guess_timezone,remove_trailing_slash) to resolve implicit inference gaps and improve IDE auto-completion.posthog/consumer.py: Explicitly typed the background worker's event collection array (items: list[Any] = []) to pass strict static variance checking.These adjustments eliminate
mypytype check errors and improve overall SDK maintainability without introducing runtime performance changes.💚 How did you test it?
mypy posthog/utils.py.pre-commit run.pytest(982 passed).📝 Checklist